Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-nginx-exporter: 0.6.0 -> 0.8.0 #105892

Merged
merged 1 commit into from Dec 4, 2020
Merged

prometheus-nginx-exporter: 0.6.0 -> 0.8.0 #105892

merged 1 commit into from Dec 4, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Dec 4, 2020 •
edited

Motivation for this change

Update the package to the current version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 105892 run on x86_64-linux 1

1 package built:
  • prometheus-nginx-exporter

@priegger
Copy link
Contributor Author

priegger commented Dec 4, 2020

Result of nixpkgs-review pr 105892 1

1 package built:
  • prometheus-nginx-exporter

@RaghavSood RaghavSood merged commit e57fa51 into NixOS:master Dec 4, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105892 run on x86_64-darwin 1

1 package built:
  • prometheus-nginx-exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@benley benley Awaiting requested review from benley

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@priegger @RaghavSood @SuperSandro2000