Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.qasm2image: remove #106495

Merged
merged 1 commit into from Dec 11, 2020
Merged

pythonPackages.qasm2image: remove #106495

merged 1 commit into from Dec 11, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Dec 9, 2020 •
edited

Motivation for this change

Remove due to prolonged breakage. It hasn't been updated since Nov. 2018, and I think a lot of the functionality has been wrapped into the mainline pythonPackages.qiskit package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
pythonPackages.qasm2image: remove
ef99419 
Removed due to: prolonged breakage (at least since Jan. 2020),
inactivity on the upstream repo (no commits since November 2018),
and no longer being compatible with pythonPackages.qiskit.
@drewrisinger drewrisinger mentioned this pull request Dec 10, 2020
Merged
10 tasks
@Mic92 Mic92 merged commit f791bd9 into NixOS:master Dec 11, 2020
@drewrisinger drewrisinger deleted the dr-pr-remove-qasm2image branch December 11, 2020 13:41
@jonringer
Copy link
Contributor

thanks :)

@drewrisinger
Copy link
Contributor Author

Yeah, I got sick of seeing it broken all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @jonringer @Mic92