Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt-rss-plugin-fever: Init at 2.2.0 #106493

Closed
wants to merge 1 commit into from

Conversation

Madahin
Copy link

@Madahin Madahin commented Dec 9, 2020

Motivation for this change

Added tinytinyrss-fever-plugin

This is a plugin to add a fever endpoint to tiny tiny rss. It is usefull for some agregator like NewsFlash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
Copy link
Member

ajs124 commented Dec 9, 2020

Supersedes #65532

'';
license = licenses.gpl3;
homepage = "https://github.com/DigitalDJ/tinytinyrss-fever-plugin";
maintainers = with maintainers; [ madahin ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this into a separate commit with the message maintainers: add madahin.

cp *.php $out/fever
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

This allows Fever compatible RSS clients to use Tiny Tiny RSS.
end-point URL is https://example.com/tt-rss/plugins.local/fever/
'';
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only or Plus?

src = fetchFromGitHub {
owner = "DigitalDJ";
repo = "tinytinyrss-fever-plugin";
rev = "${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "${version}";
rev = version;

Comment on lines +1 to +2
{ stdenv, fetchFromGitHub, ... }: stdenv.mkDerivation rec {
pname = "tt-rss-plugin-fever";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchFromGitHub, ... }: stdenv.mkDerivation rec {
pname = "tt-rss-plugin-fever";
{ stdenv, fetchFromGitHub }:
stdenv.mkDerivation rec {
pname = "tt-rss-plugin-fever";

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 12. first-time contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants