Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melonDS: 0.8.3 -> 0.9 (and build fix) #106489

Merged
merged 1 commit into from Dec 9, 2020
Merged

melonDS: 0.8.3 -> 0.9 (and build fix) #106489

merged 1 commit into from Dec 9, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

https://hydra.nixos.org/build/131268796

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It runs fine but I don't use it and don't really know if it actually works fine.
@artemist
@benley

@ofborg ofborg bot requested review from benley and artemist December 9, 2020 21:47
benley
benley approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@benley benley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@benley benley merged commit dc09a89 into NixOS:master Dec 9, 2020
@SCOTT-HAMILTON
Copy link
Contributor Author

Oh, just realize we should probably remove wrapGappsHook now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benley benley benley approved these changes

@artemist artemist Awaiting requested review from artemist

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SCOTT-HAMILTON @benley