Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages: add ppxlib 0.20.0 and split ppxlib versions into different attrs #106350

Closed
wants to merge 3 commits into from
Closed

ocamlPackages: add ppxlib 0.20.0 and split ppxlib versions into different attrs #106350

wants to merge 3 commits into from

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Dec 8, 2020 •
edited

Motivation for this change

Some new packages require newer ppxlib versions, but we can't update the 0.12.0 version we have, since it would break a lot of packages.

Also includes cinaps from #106344.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

With the janeStreet update being merged, I'll have to redo this PR. I originally split up the attributes because I felt like the dependencies of the version differed too much, but I think its possible to squeeze a > 0.16 version into the extended param approach we have now.

I'll try that when I try to update cstruct to 6.0.0…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sternenseemann