Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam-installer: init at 2.0.7 #106346

Merged
merged 1 commit into from Jan 26, 2021
Merged

opam-installer: init at 2.0.7 #106346

merged 1 commit into from Jan 26, 2021

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Standalone opam-installer package, similarly lightweight as opaline.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from henrytill and marsam December 8, 2020 12:42
@marsam
Copy link
Contributor

marsam commented Jan 24, 2021

Would you mind moving it to ocamlPackages? I think it would make it easier to maintain

@sternenseemann
Copy link
Member Author

I think it makes sense for consistency as both opaline and opam are in top-level.

@vbgl
Copy link
Contributor

vbgl commented Jan 25, 2021

I agree that this package does not belong to the ocamlPackages set. Mario, could you explain how that would ease maintenance?

BTW, it won’t build unless useDune2 is set.

@sternenseemann
Copy link
Member Author

BTW, it won’t build unless useDune2 is set.

Thanks for the hint, forgot to test this PR against the updated opam-file-format. Should be working now.

@vbgl vbgl merged commit f0a821a into NixOS:master Jan 26, 2021
@sternenseemann sternenseemann deleted the opam-installer branch January 26, 2021 11:23
@sternenseemann sternenseemann restored the opam-installer branch July 24, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrytill henrytill Awaiting requested review from henrytill

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @marsam @vbgl