libtapi: build the 'tapi' executable #106348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
reviewed
Dec 8, 2020
| @@ -19,6 +19,10 @@ stdenv.mkDerivation rec { | |||
| # not allowed for the stdenv. | |||
| buildInputs = [ ncurses ]; | |||
|
|
|||
| postPatch = '' | |||
| patch -p3 < ${./build-tapi-command.patch} | |||
There was a problem hiding this comment.
Could you open a PR at https://github.com/tpoechtrager/apple-libtapi with this change? This should help make sure this stays up to date.
There was a problem hiding this comment.
I've opened a upstream PR in tpoechtrager/apple-libtapi#17
|
The problem with zippered binaries seems to have been resolved with the latest version of libtapi. I was successfully able to create TBD files from |
midchildan
added a commit
to midchildan/nixpkgs
that referenced
this pull request
Dec 20, 2020
10 tasks
|
I've created a new PR at #107262, which no longer requires patching. |
f4814
pushed a commit
to f4814/nixpkgs
that referenced
this pull request
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds the
tapiexecutable to the libtapi package. Thetapiexecutable can be used to create TBD files, i.e. text-based stubs for macOS dynamic libraries.The main use I have in mind for this is osxfuse (now macFUSE). The osxfuse library in nixpkgs is currently built from source, but this sadly isn't ideal because the library is closely tied to the osxfuse kernel extension which isn't packaged in nixpkgs. Replacing the current osxfuse library with a TBD would make FUSE packages work more reliably by making it link to the osxfuse library that matches its kernel counterpart.
I also did a quick check to see if I could use this copy of the tapi executable to generate darwin-stubs, but that unfortunately didn't seem to work out well. This version of tapi lacks support for "zippered" binaries (whatever that means), so it couldn't generate a TBD for
libSystem.B.dylib.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Package closure size