Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additive operators for converting vector-valued and affine valued polynomials #2996

Merged
merged 7 commits into from
May 26, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented May 25, 2021

For some mysterious reason one of the four causes MSVC to go down the path of insanity. We'll live with the rest.

@@ -201,6 +207,30 @@ class PolynomialInMonomialBasis : public Polynomial<Value_, Argument_> {
friend operator*(
PolynomialInMonomialBasis<L, A, l, E> const& left,
PolynomialInMonomialBasis<R, A, r, E> const& right);
#if PRINCIPIA_COMPILER_MSVC_HANDLES_POLYNOMIAL_OPERATORS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line and a comment

// Operators polynomial ± constant.

So that the semantic of the V or A is clear.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but not here, in the real declarations. These are the friend declarations, and we keep them as compact/cryptic a possible.

@eggrobin eggrobin added the LGTM label May 25, 2021
@pleroy pleroy merged commit e42f7cf into mockingbirdnest:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants