Change: by default, make "unload all" leave stations empty #9301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9265
Motivation / Problem
Although you never have to use the
Unload
button, from a flow perspective it is very tempted to do:Full load in station A
Unload in station B
To make a one-way trip happen.
Sadly, by default,
Unload
button makes itUnload and take cargo
. This means that if for any reason the same cargo you are unloading is available at station B, it starts to load it up again. This is often unexpected, as shown by #9265. People also have a really hard time to come up with scenarios where this default makes sense.Description
The current default makes total sense code-wise. By default the loading is set to "take cargo", and the
Unload
button merely toggles the unload state toUnload all
orUnload if possible
.Either way,
Transfer
already toggles toand leave empty
, so with this PR so thatUnload
.Limitations
The order GUI is annoyingly weird, and makes little sense if you really play with it. Now if you press
Unload
twice, it doesn't return to the original state, but leavesno loading
on. Transfer already had similar issues. Resolving this requires a nice change of the full Order GUI .. not for this PR :DChecklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.