Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable #9330
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
FindVersion.cmake
is ran viacmake -P
andWIN32
is only set on windows systems.When cross-compiling for windows from linux,
WIN32
is set via the toolchain so configuration works, butcmake -P
doesn't have it at build time.Description
Explicitly tell FindVersion.cmake it's targeting windows.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.