ci/msys2: FFTS is now available in MSYS2 repos #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also update the build instructions in the README file and scopehal-docs to reflect that FFTS no longer has to be built from source on Windows. |
|
Should that be done before or after merging this change into master? |
Push the change to scopehal-docs first. Then change the README in this repo and update the scopehal-docs submodule reference as part of this PR. That way we get an atomic switchover. |
|
I updated the doc submodule. I'm not sure the README needs to be updated, since it points to the docs in the section about Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scopehal does not have an strong dependency on the master branch of FFTS. Moreover, FFTS is not updated frequently. Since FFTS is now available in MSYS2 repos, I believe there is no point in buiding it from sources here. Instead, this PR installs FFT through pacman, as done with other dependencies.