Codechange: add a wrapper function to find all settings based on prefix #9312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
settings-rework-3
branch
2 times, most recently
from
6d729f0
to
403a56e
Compare
TrueBrain
force-pushed
the
settings-rework-3
branch
from
403a56e
to
7f562bd
Compare
rubidium42
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9311.
Motivation / Problem
One more piece of code that depends on index access into
_settings.Description
After this,
_settingsis free of indexed access, meaning we can finally start splitting it into several arrays after this PR.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.