Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading FORCE_INLINE #3018

Merged
merged 1 commit into from
May 30, 2021

Conversation

eggrobin
Copy link
Member

These functions are virtual (and overriding), and all calls to them are virtual, since we never direct calls such as

p.PolynomialInMonomialBasis<Value, Argument, degree, Evaluator>::operator()(x);

As a result, they are never inlined.
See godbolt.

This may be a good thing (inlining an evaluation of a polynomial of degree 16 may be abusive).
Perhaps we would want an inlinable (but not force-inlined) evaluation for polynomials of small known degree (e.g. in special functions), but it would have to be a separate non-virtual function.

@pleroy pleroy added the LGTM label May 30, 2021
@eggrobin eggrobin merged commit 53ce160 into mockingbirdnest:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants