Remove misleading FORCE_INLINE #3018
Merged
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are virtual (and overriding), and all calls to them are virtual, since we never direct calls such as
p.PolynomialInMonomialBasis<Value, Argument, degree, Evaluator>::operator()(x);
As a result, they are never inlined.
See godbolt.
This may be a good thing (inlining an evaluation of a polynomial of degree 16 may be abusive).
Perhaps we would want an inlinable (but not force-inlined) evaluation for polynomials of small known degree (e.g. in special functions), but it would have to be a separate non-virtual function.