-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FMA for geometry #3022
FMA for geometry #3022
Conversation
@@ -288,6 +288,82 @@ Multivector<Quotient<LScalar, RScalar>, Frame, rank> | |||
operator/(Multivector<LScalar, Frame, rank> const& left, | |||
RScalar const& right); | |||
|
|||
template<typename LScalar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't trust clang-format
for template parameter lists, it just puts too much vertical space; follow everywhere the style of lines 285-286.
numerics/fma_test.cpp
Outdated
@@ -18,8 +18,7 @@ class FMATest : public testing::Test {}; | |||
TEST_F(FMATest, FMA) { | |||
// Note that we test even if |UseHardwareFMA| is false, i.e., even in debug. | |||
if (!CanEmitFMAInstructions || !HasCPUFeatures(CPUFeatureFlags::FMA)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probable make sense to put that code in the SetUp
method of the fixture, since I don't imagine any test in this file ever wanting to run if there is no FMA.
This will make it possible to use FMA in the polynomials.