Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMA for geometry #3022

Merged
merged 14 commits into from
Jun 2, 2021
Merged

FMA for geometry #3022

merged 14 commits into from
Jun 2, 2021

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jun 2, 2021

This will make it possible to use FMA in the polynomials.

@@ -18,8 +18,7 @@ class FMATest : public testing::Test {};
TEST_F(FMATest, FMA) {
// Note that we test even if |UseHardwareFMA| is false, i.e., even in debug.
if (!CanEmitFMAInstructions || !HasCPUFeatures(CPUFeatureFlags::FMA)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probable make sense to put that code in the SetUp method of the fixture, since I don't imagine any test in this file ever wanting to run if there is no FMA.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Jun 2, 2021
@eggrobin eggrobin merged commit 4ce9d9c into mockingbirdnest:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants