Factor out PS2 #161
Merged
Factor out PS2 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems fine to use "ps2"; we don't use "sdcard_host" or "spi_flash_host" (whichever suffix you prefer), even though in principle you could emulate all those on an FPGA. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following FPGAs have one or two PS/2 ports to attach a mouse and keyboard with simply a clock and data signal directly connected to the FPGA:
This commit factors out the PS2 resource by defining a function
PS2Resourcethat takes the clock signal asclkand the data signal asdat, and replaces any generic resource usingResourcewithPS2Resource.Boards either use "ps2" or "ps2_host" as a name, and I have used the "ps2" name in
PS2Resource. We can use the "ps2_host" name instead, but I personally much more prefer the controller/peripheral naming if we do that.This addresses issue #126.