Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4d1b8d001e94
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b9bdc482d000
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on May 28, 2021

  1. Remove a bug work-around.

    pleroy committed May 28, 2021
    Copy the full SHA
    c403399 View commit details
  2. c++latest now works.

    pleroy committed May 28, 2021
    Copy the full SHA
    fb4b6dd View commit details
  3. Merge pull request #3003 from pleroy/VS2019

    Remove work-arounds for VS 2019 bugs
    pleroy authored May 28, 2021
    Copy the full SHA
    b9bdc48 View commit details
Showing with 1 addition and 11 deletions.
  1. +1 −3 geometry/orthogonal_map_body.hpp
  2. +0 −8 numerics/polynomial_body.hpp
4 changes: 1 addition & 3 deletions geometry/orthogonal_map_body.hpp
Original file line number Diff line number Diff line change
@@ -68,10 +68,8 @@ OrthogonalMap<FromFrame, ToFrame>::operator()(T const& t) const {
return base::Mappable<OrthogonalMap, T>::Do(*this, t);
}

// NOTE(phl): VS2019 wants us to name the types F and T below, even though it is
// happy with ReadFromMessage below. You can't explain that.
template<typename FromFrame, typename ToFrame>
template<typename F, typename T, typename>
template<typename, typename, typename>
OrthogonalMap<FromFrame, ToFrame>
OrthogonalMap<FromFrame, ToFrame>::Identity() {
return OrthogonalMap(Quaternion(1));
8 changes: 0 additions & 8 deletions numerics/polynomial_body.hpp
Original file line number Diff line number Diff line change
@@ -514,11 +514,7 @@ template<typename Value_, typename Argument_, int degree_,
PolynomialInMonomialBasis<Value_, Argument_, degree_, Evaluator>&
PolynomialInMonomialBasis<Value_, Argument_, degree_, Evaluator>::
operator+=(PolynomialInMonomialBasis const& right) {
#if PRINCIPIA_COMPILER_MSVC
this->coefficients_ = this->coefficients_ + right.coefficients_;
#else
*this = *this + right;
#endif
return *this;
}

@@ -527,11 +523,7 @@ template<typename Value_, typename Argument_, int degree_,
PolynomialInMonomialBasis<Value_, Argument_, degree_, Evaluator>&
PolynomialInMonomialBasis<Value_, Argument_, degree_, Evaluator>::
operator-=(PolynomialInMonomialBasis const& right) {
#if PRINCIPIA_COMPILER_MSVC
this->coefficients_ = this->coefficients_ - right.coefficients_;
#else
*this = *this - right;
#endif
return *this;
}