Codechange: make [Save|Load]Settings() behave more like other Save/Load code #9335
+47
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9333 (not really needed, but I don't want to conflict-resolve it later on).
Motivation / Problem
One of these things .. Settings SaveLoad had custom code which was rather difficult to read.
Description
The code is now much simpler. First it prepares what it will load. Next it loads it.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.