Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: rename _SQ64 into POINTER_IS_64BIT #9313

Merged
merged 1 commit into from
May 30, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

I was looking through the code and found an remnant of the past.

Description

Back in the day Squirrel could be compiled either 32bit or 64bit. _SQ64 indicate which of the two. This of course was problematic, as we had AIs that did work on a 64bit system, but failed on a 32bit. So yeah .. since 39e90ec Squirrel is always in 64bit mode.

Just ... some people found out that _SQ64 indicate if the system was 64bit or not, and started to use that in a few other places in the code too. And so now we are left with a codebase where the reference to Squirrel is lost in the meaning of the define (read: it is not used anywhere in Squirrel, yet carries the name).

So, lets rename the variable in to what it means, so the other usages feel a bit more legit :) We are now _SQ64 free! \o/

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit bcd7a7a into OpenTTD:master May 30, 2021
@TrueBrain TrueBrain deleted the rename-sq64 branch May 30, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants