Codechange: rename _SQ64 into POINTER_IS_64BIT #9313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
I was looking through the code and found an remnant of the past.
Description
Back in the day Squirrel could be compiled either 32bit or 64bit.
_SQ64
indicate which of the two. This of course was problematic, as we had AIs that did work on a 64bit system, but failed on a 32bit. So yeah .. since 39e90ec Squirrel is always in 64bit mode.Just ... some people found out that
_SQ64
indicate if the system was 64bit or not, and started to use that in a few other places in the code too. And so now we are left with a codebase where the reference to Squirrel is lost in the meaning of the define (read: it is not used anywhere in Squirrel, yet carries the name).So, lets rename the variable in to what it means, so the other usages feel a bit more legit :) We are now
_SQ64
free! \o/Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.