Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #474 (BSD build support) #489

Merged
merged 2 commits into from
May 31, 2021
Merged

fix #474 (BSD build support) #489

merged 2 commits into from
May 31, 2021
+16 −5

Conversation

spookyvision
Copy link
Contributor

fix #474

ericonr
ericonr reviewed May 31, 2021
View reviewed changes
@@ -10,6 +11,11 @@ else()
set(LIN_LIBS dl)
endif()

# adapt for BSD pthreads API
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this comment is wrong? This is about struct stat, not pthreads.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that certainly explains my error :D (I was mixing up two things, therefore the "BSD" if)

@azonenberg azonenberg merged commit 1bae7a2 into ngscopeclient:master May 31, 2021
@MegabytePhreak MegabytePhreak mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericonr ericonr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BSD build support
3 participants
@spookyvision @ericonr @azonenberg