New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BSD build support (#345) #366

Merged

azonenberg merged 2 commits into ngscopeclient:master from spookyvision:intel_mac

May 31, 2021

Contributor

spookyvision commented May 31, 2021

fix #345


          fix ngscopeclient#345

613118e

ericonr reviewed

View reviewed changes

src/glscopeclient/WaveformProcessingThread.cpp Outdated

Comment on lines 44 to 51

+              	#if defined(unix) || defined(__unix__) || defined(__unix)
+              		#if __linux__
+              		// on Linux, max 16 chars including \0, see man page
+              		pthread_setname_np(pthread_self(), "WaveformThread");
+              		#else
+              		// BSD, including Apple
+              		pthread_setname_np("WaveformThread");
+              		#endif

ericonr May 31, 2021

I wonder if this logic couldn't be made into a utility function? This way you'd avoid repeating the ifdefs all across the code base.


          pthread compat wrapper

cb8482a

azonenberg merged commit 15a189d into ngscopeclient:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment