Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factor out VGAResource #159

Closed
wants to merge 1 commit into from
Closed

factor out VGAResource #159

wants to merge 1 commit into from

Conversation

StephanvanSchaik
Copy link
Contributor

The following boards all feature a VGA port with an R2R DAC that is directly connected to the FPGA.

  • DE0
  • DE0-CV
  • DE10-Lite
  • Genesys2
  • Mercury
  • MiSTer
  • Nexys4DDR
  • RZEasyFPGAA2.2

The following commit factors out this resource into a VGAResource function and replaces any generic instance using Resource of such a VGA resource with a call to VGAResource instead. As some boards require an inverted signal for the horizontal and vertical sync pins, the VGAResource function also features an invert_sync parameter to invert the synchronization signals. This addresses issue #127.

@whitequark
Copy link
Member

This renames hs and vs to hsync and vsync, right? That's a breaking change.

@StephanvanSchaik
Copy link
Contributor Author

This renames hs and vs to hsync and vsync, right? That's a breaking change.

Yes, we can also stick to hs and vs, but there are also a few boards that use hsync and vsync unfortunately. I think I did see more occurrences of hs and vs, though.

@whitequark
Copy link
Member

Let's go for hs and vs then.

@StephanvanSchaik StephanvanSchaik mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StephanvanSchaik @whitequark