Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: use AsIntSetting()->Read() wrapper if possible #9324

Merged
merged 1 commit into from May 31, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Two places still used the old ways of accessing setting variables. We now have a shiny new method!

Description

Use Settings wrappers to access values of Settings (instead of accessing the backend storage yourself).

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit 921ab68 into OpenTTD:master May 31, 2021
@TrueBrain TrueBrain deleted the settings-rework-3 branch May 31, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants