factor out VGAResource (rev. 1) #160
Merged
+62
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
hs
andvs
naming instead ofhsync
andvsync
used by the previous pull request to break compatibility a little bit less as most boards, but unfortunately not all, are usinghs
andvs
.The following boards all feature a VGA port with an R2R DAC that is directly connected to the FPGA.
The following commit factors out this resource into a
VGAResource
function and replaces any generic instance usingResource
of such a VGA resource with a call toVGAResource
instead. As some boards require an inverted signal for the horizontal and vertical sync pins, theVGAResource
function also features aninvert_sync
parameter to invert the synchronization signals. This addresses issue #127.