Missing unblock of load event in display:none iframe #29216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 4, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2940528
branch
2 times, most recently
from
6b7e5c8
to
fecf09b
Compare
If we inserted an object into a display:none iframe during parsing after we had updated the layout tree, we would not unblock the load event because we did not unblock when the layout tree update was a no-op. This typically happens because inserting elements into a non-rendered subtree which is up-to-date does not require a subsequent update. Makes the html-parser-threaded.html performance test start working again. Bug: 1216353 Change-Id: I3e5b0390c45b9e0411fe10fb22a686f39791a66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940528 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#891482}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2940528
branch
from
fecf09b
to
de1b591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we inserted an object into a display:none iframe during parsing after
we had updated the layout tree, we would not unblock the load event
because we did not unblock when the layout tree update was a no-op. This
typically happens because inserting elements into a non-rendered subtree
which is up-to-date does not require a subsequent update.
Makes the html-parser-threaded.html performance test start working
again.
Bug: 1216353
Change-Id: I3e5b0390c45b9e0411fe10fb22a686f39791a66f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940528
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891482}