Motivation / Problem

A crash that happened from time to time, but nobody could reproduce. Took me a long time staring at the traceback to figure out what causes it. But as written in the commit message:

If you update the server-list while not having last-joined selected
and it is no longer available, the game crashed.

Description

We only removed last_joined selection in the GUI if it was selected and no longer available. Also remove it if it is not selected, as drawing it will obvious fail.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker