Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Wrong unreservation behaviour when reversing a train inside a depot when an incoming reservation exists #9520

Closed
JGRennison opened this issue Aug 28, 2021 · 1 comment · Fixed by #9557
Closed

[Bug]: Wrong unreservation behaviour when reversing a train inside a depot when an incoming reservation exists #9520

JGRennison opened this issue Aug 28, 2021 · 1 comment · Fixed by #9557
Milestone
12.0

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

master (aa83488)

Expected result

Pressing the reverse button when a train is waiting inside a depot does not cause any PBS reservation issues.
Any incoming reservations should be unaffected.

Actual result

When there is an incoming reservation into a depot, pressing the reverse button on a train inside the depot removes the entire incoming reservation, including from underneath the incoming train.
The depot tile is then left reserved. This can result in the depot being permanently blocked without user intervention if the incoming train does not then continue into the depot.

Steps to reproduce

  1. Load: JGR Rail Testing Ltd., 1980-02-25.sav.zip.
  2. Press reverse button on Train 2.
  3. Note that Train 1's reservation has been removed, and the depot tile has been left reserved.
@JGRennison JGRennison mentioned this issue Aug 28, 2021
Closed
@TrueBrain TrueBrain added this to the 12.0 milestone Aug 29, 2021
JGRennison added a commit to JGRennison/OpenTTD-patches that referenced this issue Aug 29, 2021
@JGRennison
Prevent train reversing when wholly inside a train depot
fea967b 
See: #316, OpenTTD/OpenTTD#9520
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Sep 18, 2021
@JGRennison @TrueBrain
Prevent train reversing when wholly inside a train depot
b4b45a9 
See: OpenTTD#316, OpenTTD#9520
@TrueBrain TrueBrain mentioned this issue Sep 18, 2021
Merged
@TrueBrain
Copy link
Member

Beautiful savegame to test this bug with. Tnx a lot for that @JGRennison , this is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging a pull request may close this issue.

Fix: Prevent train reversing when wholly inside a train depot TrueBrain/OpenTTD
2 participants
@TrueBrain @JGRennison