Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Switching server from public to invite-only from 'online players' window gives an error #61

Closed
ldpl opened this issue Sep 2, 2021 · 1 comment
Closed

[Bug]: Switching server from public to invite-only from 'online players' window gives an error #61

ldpl opened this issue Sep 2, 2021 · 1 comment

Comments

@ldpl
Copy link

ldpl commented Sep 2, 2021

Version of OpenTTD

master(92559e6)

Expected result

Switch to invite-only since it works fine if switched public->local->invite-only.

Actual result

Screenshot from 2021-09-02 21-20-21

Steps to reproduce

  1. Start a server
  2. Switch visibility to public.
  3. Switch visibility to invite-only.
@TrueBrain TrueBrain transferred this issue from OpenTTD/OpenTTD Sep 2, 2021
@TrueBrain
Copy link
Member

Moved to here, as it is a GC bug (OP couldn't have known).

https://github.com/OpenTTD/game-coordinator/blob/main/game_coordinator/application/coordinator.py#L238

This needs some more magic to understand when it is the same server over the same TCP connection doing this.

TrueBrain added a commit to TrueBrain/OpenTTD-game-coordinator that referenced this issue Sep 2, 2021
@TrueBrain
Fix OpenTTD#61: changing server information was considered "reuse if …
28ff56e 
…invite code"
TrueBrain added a commit to TrueBrain/OpenTTD-game-coordinator that referenced this issue Sep 2, 2021
@TrueBrain
Fix OpenTTD#61: changing server information was considered "reuse if …
8ae1c58 
…invite code"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ldpl @TrueBrain