Fix: use-after-free after ClientNetworkCoordinatorSocketHandler::CloseAllConnections() #9534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
While debugging a GC issue, I managed to cause a use-after-free. Example flow:
Start your own server, and while your server is being probed (takes ~3 seconds), kill the connection (for example by modifying the code or running your own GC that does this).
Possibly there are other ways to trigger a
CloseAllConnections
.Description
I have no clue why I initially wrote it in
CloseConnection()
with this comment, and that worries me a bit. I remember there was something special about these objects, but .. yeah, can't remember, and this seems to be the proper solution.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.