Fix: conclude server-probe earlier if all results are in #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, change the direct-ip-detection timeout to three seconds instead of one, to give servers more time to respond.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, change the direct-ip-detection timeout to three
seconds instead of one, to give servers more time to respond.
Before this PR, server-probe always took 2-seconds, no matter what type of server you had. But we had enough information to conclude a lot earlier in many situations.
Additionally, we only wait 1 seconds for direct-ip-detection to conclude, which is rather tight. OpenTTD itself gives connections 3 seconds, so we should do the same.
In result, with this PR:
As fallback, in case we have a bug or what-ever in the above, after 7 seconds it concludes no matter what. This really is just a safe-guard.