Fix #9490: [Network] a full server couldn't be queried either #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now still query a full server, as long as the maximum amount of allowed connections isn't reached. This means that as long as there are not 255 clients connected to a server, you can always connect to query.
rubidium42
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Still leaves the concurrency issue open that clients_on is checked upon join but only incremented much later, so multiple clients could pass this "gate" before the count in incremented thus essentially allowing more clients to join than the configured maximum.
It's fine to move that to a separate story though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#9490 shows that querying a full server wasn't possible. In most cases there isn't really a reason to not allow this.
Description
Basically, you are now allowed to do a
GAME_INFOpacket despite the server being full.CLIENT_JOINis the first packet checking if the server is really full (and drops the connection if it is). All other packets require thatCLIENT_JOINwas successful, and otherwise they return aNOT_EXPECTEDerror.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.