Fix: [Network] don't show GameScript " (v0)" for old servers #9507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Found a bug during playtesting. When a 1.11.2 server doesn't have a GS, it is shown as
(v0)
.Description
This happens because if you do send the NetworkGameInfo as v4 or earlier, the GS version remained its initial value (0), which makes it show up like that. For GS version, the default value should be
-1
.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.