Codechange: rework how connections are setup #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a magic queue and wait for connection methods to arrive on it, make a bit more use of coroutines and just write in a single functions all the connection methods and their order. This makes the whole function a lot less magic and more readable. Accidental this might fix several issues, and report better statistics about what is failing when.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a magic queue and wait for connection methods
to arrive on it, make a bit more use of coroutines and just write
in a single functions all the connection methods and their order.
This makes the whole function a lot less magic and more readable.
Accidental this might fix several issues, and report better
statistics about what is failing when.