Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a2051bad: SendCmdNames only sent one name per packet #9528

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

@Xaroth noticed that the CmdNames came in one per packet, instead of all in a single packet.

Description

A simple logic error. a2051ba flipped the statement around.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain changed the title Fix a2051bad: SendCmdNames doesn't fill up a packet as much as possible Fix a2051bad: SendCmdNames only sent one name per packet Aug 31, 2021
@TrueBrain TrueBrain merged commit 63116bd into OpenTTD:master Aug 31, 2021
@TrueBrain TrueBrain deleted the fix-admin-send-names branch August 31, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants