Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A diurnal test that reads Butcher’s save #3108

Merged
merged 2 commits into from
Aug 22, 2021

Conversation

eggrobin
Copy link
Member

Diurnal not because it is especially slow (103 s on my machine), but because the save is 44 MB and we might not want to check that in.
Progress towards #1119. Does not actually investigate the Лидов–古在 mechanism, that will be a job for an astronomy test, but gives us an initial state for such a test.


plugin->RequestReanimation(begin->time);

while (mercury.trajectory().t_min() > begin->time) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polling?! Please use WaitForReanimation.

Sorry, something went wrong.

Copy link
Member Author

@eggrobin eggrobin Aug 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no WaitForReanimation in the plugin; I don’t have an ephemeris.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Aug 22, 2021
@eggrobin eggrobin merged commit 4c5d6bc into mockingbirdnest:master Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants