Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the code generation to a post-build event of the tools project #3107

Merged
merged 3 commits into from
Aug 21, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Aug 21, 2021

This means that we can compile ksp_plugin_test without having to compile ksp_plugin.

<Import Project="..\third_party_zfp.props" />
</ImportGroup>
<Import Project="..\third_party_zfp.props" />
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only in debug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mistake.

@eggrobin eggrobin added the LGTM label Aug 21, 2021
@pleroy pleroy merged commit 874e4db into mockingbirdnest:master Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants