Fix: [Network] show query errors in the server listing instead of error popup #9506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubidium42
reviewed
Aug 23, 2021
rubidium42
previously approved these changes
Aug 23, 2021
…or popup When you are query several servers at once, it is rather unclear for which server you got a popup. Instead, show any errors on the server itself. This is only true for the query-part. Joining a server still gives an error popup to tell you about any issue.
rubidium42
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #9502.
Motivation / Problem
While investigating solutions for #9490, and with the introduction of #9502, I realised how annoying the red popups are when querying servers. It makes much more sense (to me) to show the server status in the info dialog we have for it, similar to "offline".
Description
As #9502 moved all the query code to its own file, it is a lot easier to add this. Making this PR pretty straight-forward.
And similar for "Server too old".
To be clear, this is not the final solution for #9490, but at least makes it less icky.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.