Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-16 for filenames on Windows only #3116

Merged
merged 2 commits into from
Aug 28, 2021

Conversation

eggrobin
Copy link
Member

This should fix the mac build, where our compatibility path is lacking a char16_t const* constructor.

@@ -241,5 +241,11 @@ template_and_result declared_name parameters; \
} \
using internal_##package_name::declared_name

#if OS_WIN
#define PATH_ENCODING(string) u##string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this PRINCIPIA_PATH_ENCODING.

@pleroy pleroy added the LGTM label Aug 28, 2021
@pleroy pleroy merged commit 98804e8 into mockingbirdnest:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants