You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In SlGamelogAction::LoadLoggedAction::changes is never assigned in the non IsSavegameVersionBefore(SLV_RIFF_TO_ARRAY) path. LoggedChange items are loaded into LoggedAction::change beyond the logical (but not allocated) end of the array.
When the Gamelog is cleared, pointers referenced by LoggedChange items are leaked, which is how the issue was noticed.
Steps to reproduce
Load a savegame with a version >= SLV_RIFF_TO_ARRAY (294).
Run the gamelog command or otherwise observe the gamelog.
The text was updated successfully, but these errors were encountered:
JGRennison
added a commit
to JGRennison/Upstream-OpenTTD
that referenced
this issue
Dec 10, 2021
Version of OpenTTD
master
Expected result
Gamelog loaded correctly
Actual result
In
SlGamelogAction::Load
LoggedAction::changes
is never assigned in the nonIsSavegameVersionBefore(SLV_RIFF_TO_ARRAY)
path.LoggedChange
items are loaded intoLoggedAction::change
beyond the logical (but not allocated) end of the array.When the Gamelog is cleared, pointers referenced by
LoggedChange
items are leaked, which is how the issue was noticed.Steps to reproduce
Load a savegame with a version >= SLV_RIFF_TO_ARRAY (294).
Run the
gamelog
command or otherwise observe the gamelog.The text was updated successfully, but these errors were encountered: