vendor.xilinx: add workaround for ISE #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISE doesn't support using the constraints file to specify attributes on IO buffers, this works around that by specifying them also as module parameters which ISE does support properly. Fixes amaranth-lang#641.
Codecov Report
@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 81.53% 81.53%
=======================================
Files 49 49
Lines 6468 6468
Branches 1531 1531
=======================================
Hits 5274 5274
- Misses 1002 1003 +1
+ Partials 192 191 -1
Continue to review full report at Codecov.
|
|
This PR has been in a draft status in a while and it doesn't seem like it's going anywhere, so I'll close it, and reopen if there's interest in it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISE doesn't support using the constraints file to specify attributes on
IO buffers, this works around that by specifying them also as module
parameters which ISE does support properly.
Fixes #641.
Note: This is a horrible hack in my opinion and is currently untested on ISE (in-progress). Comments welcome.