sim: represent time internally as 1ps units #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 81.53% 81.47% -0.07%
==========================================
Files 49 49
Lines 6468 6467 -1
Branches 1531 1531
==========================================
- Hits 5274 5269 -5
- Misses 1002 1005 +3
- Partials 192 193 +1
Continue to review full report at Codecov.
|
whitequark
reviewed
Dec 13, 2021
Lunaphied
force-pushed
the
fix-538
branch
4 times, most recently
from
e0fc3bd
to
1201252
Compare
Lunaphied
changed the title
Using floats to represent simulation time internally isn't ideal instead use 1ps internal units while continuing to use a floating point based interface for compatibility. Fixes amaranth-lang#535.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually represent time internally without using floating point numbers.
This is mostly important for after simulation API changes result in an API that allows user facing code to specify these parameters in exact units as well, however for now we don't wish to have a breaking change before this new API is defined.
This will make that change far more trivial and has already been tested.
Fixes #535.