Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't represent simulation time as floating point #535

Closed
whitequark opened this issue Nov 7, 2020 · 0 comments · Fixed by #651
Closed

Don't represent simulation time as floating point #535

whitequark opened this issue Nov 7, 2020 · 0 comments · Fixed by #651
Labels
improvement simulator:cxxsim simulator:pysim

Comments

@whitequark
Copy link
Member

whitequark commented Nov 7, 2020 •
edited

There's really no excuse for implementing it that way in the first place, and we should just fix it. /cc @mwkmwkmwk
@whitequark whitequark mentioned this issue Nov 7, 2020
Closed
@nturley nturley mentioned this issue Dec 12, 2020
Closed
Lunaphied added a commit to Lunaphied/amaranth that referenced this issue Dec 13, 2021
@Lunaphied
sim: represent time internally as 100ps units
c55af40 
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
@Lunaphied Lunaphied mentioned this issue Dec 13, 2021
Merged
Lunaphied added a commit to Lunaphied/amaranth that referenced this issue Dec 13, 2021
@Lunaphied
sim: represent time internally as 100ps units
80a4019 
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
Lunaphied added a commit to Lunaphied/amaranth that referenced this issue Dec 13, 2021
@Lunaphied
sim: represent time internally as 100ps units
b106d05 
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
Lunaphied added a commit to Lunaphied/amaranth that referenced this issue Dec 13, 2021
@Lunaphied
sim: represent time internally as 100ps units
1e7f7bd 
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
Lunaphied added a commit to Lunaphied/amaranth that referenced this issue Dec 13, 2021
@Lunaphied
sim: represent time internally as 100ps units
1201252 
Using floats to represent simulation time internally isn't ideal
instead use 100ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
Lunaphied added a commit to Lunaphied/amaranth that referenced this issue Dec 13, 2021
@Lunaphied
sim: represent time internally as 1ps units
2648c34 
Using floats to represent simulation time internally isn't ideal
instead use 1ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes amaranth-lang#535.
whitequark pushed a commit that referenced this issue Dec 13, 2021
@Lunaphied @whitequark
sim: represent time internally as 1ps units
1ee2482 
Using floats to represent simulation time internally isn't ideal
instead use 1ps internal units while continuing to use a floating
point based interface for compatibility.

Fixes #535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement simulator:cxxsim simulator:pysim
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sim: represent time internally as 1ps units Lunaphied/amaranth
1 participant
@whitequark