Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: inform clients what game-script a server is running #9441

Merged
merged 1 commit into from Jul 14, 2021
Merged

Add: inform clients what game-script a server is running #9441

merged 1 commit into from Jul 14, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jul 14, 2021 •
edited

Note: this is only deployed on staging; please use OTTD_COORDINATOR_CS="coordinator.openttd.org:4976" for testing. After approval and before merging this will be deployed to production.

Motivation / Problem

#9234 introduces the ability to send/receive game-script info in the server listing. This sounds like a very useful addition.

Closes #9234.

Description

This PR takes #9234, and makes it compatible with master. I also approaches some things slightly different from a coding perspective.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

James103
James103 reviewed Jul 14, 2021
View reviewed changes
src/lang/english.txt Outdated Show resolved Hide resolved
@TrueBrain TrueBrain marked this pull request as ready for review July 14, 2021 11:39
rubidium42
rubidium42 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing with the game coordinator use OTTD_COORDINATOR_CS="coordinator.openttd.org:4976"; there were a few typos in name of the environment variable name.

@TrueBrain TrueBrain merged commit c921f6d into OpenTTD:master Jul 14, 2021
@TrueBrain TrueBrain deleted the game-server-info branch July 14, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James103 James103 James103 left review comments

@rubidium42 rubidium42 rubidium42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TrueBrain @rubidium42 @James103 @TheDude-gh