Feature: parse the console settings the same way as config settings #9438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
set server_game_type
in the in-game console shows the string representation (like local and public).The configuration file uses local and public for the value of server_game_type.
But
set server_game_type public
cannot be done as public is not an integer.Description
Use the parse logic from the settings instead of the integer parsing from the console to parse the setting. This way it gets unified.
Limitations
Technically there is a more useful error message that the parse function puts onto the error list. However, extracting that requires a lot of extra effort and adds a single translated string to the console output, whereas all other errors are not translated. So, I rather leave it with this simple error message.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.