Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version numbers to the C++ DLLs #3060

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jul 11, 2021

No description provided.

pleroy added 2 commits July 11, 2021 21:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENG)
LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_UK
#pragma code_page(1252)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to set this to something more modern?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This file is generated by Visual Studio from a dedicated UI, and the UI doesn't let you choose the code page.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jul 11, 2021
@pleroy pleroy merged commit 7a735e5 into mockingbirdnest:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants