Remove: includes to network/core/config.h from headers when only three cpp files need it #9436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Changing something in network/core/config.h took ages to recompile as many .cpp files included it indirectly via settings_type.h or network_type.h even when those .h files did not need it.
Description
Remove network/core/config.h includes from two .h files and add it two three .cpp files that actually need it.
Now changing config.h requires 50 files to be recompiled, compared to 298 before this change.
Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.