Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a mechanism to exclude forks at serialization time #3063

Merged
merged 9 commits into from
Jul 15, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jul 14, 2021

Previously, only the forks listed in the forks parameter were included; they were restored on deserialization.

This doesn't work too well if there is a large number of fork to serialize, because listing them explicitly requires cumbersome bookkeeping. And really, if the history has 1000 forks, we don't want to know about them.

So I am changing the default so that all the forks rooted at a trajectory are serialized, except those listed in the excluded parameter. The ones that we are interested in, i.e., the ones that we want to restore on deserialization, are listed in tracked.

@@ -79,6 +79,11 @@ message ContinuousTrajectory {
}

message DiscreteTrajectory {
// A marker to indicate that a fork doesn't have it's position tracked.
// Added in Groethendieck/Haas.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haar, I don’t think we will have a Haas release.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jul 15, 2021
@pleroy pleroy merged commit bb48ea1 into mockingbirdnest:Entwurf Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants