Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Principia uses icon color instead of orbit color #3078

Closed
Bellabong opened this issue Jul 30, 2021 · 1 comment · Fixed by #3135
Closed

Principia uses icon color instead of orbit color #3078

Bellabong opened this issue Jul 30, 2021 · 1 comment · Fixed by #3135
Assignees
Labels

Comments

@Bellabong
Copy link

So this is pretty minor but I noticed that if Kopernicus has defined an icon color for a body that Principia uses the icon color instead of color to colour its orbit.

Principia colours:
https://i.imgur.com/Xbl1AAz.png

Actual orbit colours:
https://i.imgur.com/Ej5Duv9.png

@eggrobin
Copy link
Member

eggrobin commented Oct 2, 2021

I had a vague recollection of difficulties with the colours; poking at this I found it again: celestial.orbitDriver.orbitColor is not the right color (it is white for all planets, instead of being the colour of the stock orbits). I think the icon colour (specifically, celestial.MapObject.uiNode.VisualIconData.color) was the first thing I found that was the right colour in stock and RSS.

It seems instead I should be using celestial.orbitDriver.Renderer.orbitColor. At least that has the colour of the stock orbit in stock and RSS; KSP being KSP I don’t know whether it’s actually secretly the icon colour.

I’ll let you check that #3135—to be released in Hadamard, Wednesday—fixes the issue.

@eggrobin eggrobin added the bug label Oct 2, 2021
@eggrobin eggrobin self-assigned this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants