Cleanup #9725: Replace cmd_helper related functions and remove cmd_helper.h #9783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #9725, cmd_helper is almost useless.
The few remaining IsEnumValid() can be replaced with IsValidDirection(), IsValidAxis...
The few remaining Extract<>() in story.cpp can also be replaced.
Limitations
I don't know if there is any plan of using these again, but probably they won't.
If there is no need of keeping Extract, IsEnumValid and cmd_helper.h, it is also possible to remove EnumPropsT.
If developers think so, just say it and I will remove EnumPropsT related code in another commit to this same PR.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.