Fix #9388: thread unsafe use of NetworkAdminConsole/IConsolePrint #9456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Fixes #9388.
Some debug messages are sent from other threads than the
GameLoop
. WithNetworkAdminConsole
this might cause multiple threads adding to the queue at the same time corrupting the (linked) list ofPacket
s. WithIConsolePrint
this could also corrupt the (linked) list of lines in the console.Description
Queue the
NetworkAdminConsole
/IConsolePrint
calls from Debug (when needed) and actually "send" those from theGameLoop
.Limitations
None that I know about.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.